Update secrets manager to >=0.3.0 #63
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the secrets-manager to
v0.3.0, which includes some ways to isolate the secrets between extensions.See jupyterlab-contrib/jupyter-secrets-manager#13 for context.
With this update, the plugin that will use the secrets needs to "sign" to the secrets manager. It will receive a unique token that will be use to manage the secrets. The token is associated to a namespace, which must be the same value as the plugin id.
The token is stored to a private namespace, to prevent other extensions to be able to retrieve it.